[PATCH] D56155: [docs] cttz and ctlz return poison, not undef, when argument is 0

John Regehr via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 29 16:10:20 PST 2018


regehr marked an inline comment as done.
regehr added inline comments.


================
Comment at: docs/LangRef.rst:12251-12252
 the intrinsic should ensure that a zero as the first argument produces a
 defined result. Historically some architectures did not provide a
 defined result for zero values as efficiently, and many algorithms are
 now predicated on avoiding zero-value inputs.
----------------
lebedev.ri wrote:
> Should `defined` also be reworded, since it is no longer 'un'`defined`, but `poison`?
my view is the "undefined" is a broad term that encompasses undef and poison, so this probably doesn't require rewording

however, is_zero_undef is specifically referring to undef, and should be changed to is_zero_poison (or, perhaps, is_zero_undefined)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56155/new/

https://reviews.llvm.org/D56155





More information about the llvm-commits mailing list