[PATCH] D55961: [InstCombine] canonicalize MUL with NEG operand

ChenZheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Dec 29 15:59:33 PST 2018


shchenz marked an inline comment as done.
shchenz added a comment.

@lebedev.ri Updated. Thanks.



================
Comment at: llvm/test/Transforms/InstCombine/operand-complexity.ll:4
 
 ; 'Negate' is considered less complex than a normal binop, so the mul should have the binop as the first operand.
 
----------------
lebedev.ri wrote:
> I guess this test no longer serves it's purpose.
> Not sure what to do here.
I changed the binop here to keep original testcases. It will not change these cases testing point.
new testcases for MUL canonicalization are all in file mul.ll.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55961/new/

https://reviews.llvm.org/D55961





More information about the llvm-commits mailing list