[PATCH] D56063: [llvm-nm] Allow --size-sort to print symbols with only Symbol size

Saurabh Badhwar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 28 23:40:36 PST 2018


h4xr marked an inline comment as done.
h4xr added inline comments.


================
Comment at: tools/llvm-nm/llvm-nm.cpp:832
         strcpy(SymbolAddrStr, printBlanks);
-      else
+      else if(PrintAddress)
         format(printFormat, I->Address)
----------------
rupprecht wrote:
> Reverting this part of the change doesn't seem to cause any tests to fail, can you add a test case that covers it?
Hi, I have improved the test cases to account for covering the output when PrintAddress is also supplied. Please let me know, if that is the expected test case here, I will be more than happy to improve the test scenario if I understood it wrong :)


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56063/new/

https://reviews.llvm.org/D56063





More information about the llvm-commits mailing list