[PATCH] D56138: [Sanitizer] Enable getfsent api for Darwin/Linux

[Kamil Rytarowski via Phabricator via llvm-commits]

krytarowski added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:9061
   COMMON_INTERCEPTOR_ENTER(ctx, getfsspec, spec);
-  if (spec)
+  if (common_flags()->strict_string_checks && spec)
     COMMON_INTERCEPTOR_READ_RANGE(ctx, spec, REAL(strlen)(spec) + 1);
----------------
devnexen wrote:
> krytarowski wrote:
> > Why is it needed?
> The unit test fails on Linux with msan.
I would fix that failure on Linux rather than papering over the problem.

Or just enable it for Darwin and skip it until Linux people will port it.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56138/new/

https://reviews.llvm.org/D56138