[PATCH] D56109: [sanitizer_common] Define __sanitizer_FILE on NetBSD

Michał Górny via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 28 10:24:49 PST 2018


mgorny added reviewers: eugenis, kcc.
mgorny added a comment.

We've been discussing this, and I think we're doing this the wrong way. Could you help me a little understand this?

In particular, what is the purpose of unpoisoning file? Is it in order to account for stdio functions being implemented inline or as macros, and therefore user code accessing internal `FILE` members? Or is there some other use case for this?

If only the former, then I think there is no purpose in definining `__sanitizer_FILE` on NetBSD, as we support only reentrant interfaces which are all implemented as libc routine calls.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56109/new/

https://reviews.llvm.org/D56109





More information about the llvm-commits mailing list