[PATCH] D56119: [PowerPC] Fix ADDE, SUBE do not know how to promote operator

Fri Dec 28 09:23:57 PST 2018

ZhangKang marked 2 inline comments as done.
ZhangKang added inline comments.

================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp:146
   case ISD::ADDCARRY:
   case ISD::SUBCARRY:    Res = PromoteIntRes_ADDSUBCARRY(N, ResNo); break;

----------------
hfinkel wrote:
> I think that this works, but...
> 
> Please add a comment to PromoteIntRes_ADDSUBCARRY stating that it is also handling promotion for the ADDE/SUBE nodes (which differ from the ADDCARRY/SUBCARRY nodes in that the third operand is the input carry flag instead of a carry Boolean).
> 
> LGTM.
> 
I have added comments for `PromoteIntRes_ADDSUBCARRY`.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56119/new/

https://reviews.llvm.org/D56119