[PATCH] D56125: [Sanitizer] Intercept arc4random_buf on FreeBSD/NetBSD

David CARLIER via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 28 03:59:37 PST 2018


devnexen added a comment.

I did oi

In D56125#1341748 <https://reviews.llvm.org/D56125#1341748>, @krytarowski wrote:

> Can you add an interceptor for `arc4random_addrandom` too?
>
> Please rework test to stop triggering an issue, we just want to check whether correct usage of API makes no false alarms from sanitizers.


Agreed for the first point, I waited first feedback before doing so.
About test I did on purpose because arc4random is kinda "boring" (ie works too "well" :-)) but I will change it no worries...


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56125/new/

https://reviews.llvm.org/D56125





More information about the llvm-commits mailing list