[PATCH] D56117: [ThinLTO] Scan all variants of vague symbol for reachability.
George Rimar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 27 23:36:29 PST 2018
grimar added a comment.
I think this is perhaps fine, a minor comment is below. Also, I think Teresa should give a final accept, not me :)
================
Comment at: lib/Transforms/IPO/FunctionImport.cpp:785
+ [](const std::unique_ptr<llvm::GlobalValueSummary> &S)
+ -> bool { return S->isLive(); }))
+ return;
----------------
You can omit `-> bool`:
```
if (llvm::all_of(VI.getSummaryList(),
[](const std::unique_ptr<llvm::GlobalValueSummary> &S) {
return S->isLive();
}))
return;
```
Repository:
rL LLVM
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56117/new/
https://reviews.llvm.org/D56117
More information about the llvm-commits
mailing list