[PATCH] D55638: [CallSite removal] Add and flesh out APIs on the new `CallBase` base class that previously were only available on the `CallSite` wrapper.

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added a comment.

In D55638#1341290 <https://reviews.llvm.org/D55638#1341290>, @compnerd wrote:

> The only minor nit is the preference for `Known` in some of the operand checks.  IIRC clang doesn't get 100% of the annotations, so even if something is not marked as `noread`, it may be `noread`.  Yes, its nit-picky, but, I think it helps when dealing with code that you are unfamiliar with (or happen to page out the context from clang).


I totally agree w/ your suggestion, but I'd like to do this after `CallSite` is gone. My goal is to make the APIs interchangable first, and then we can do updates to them. Does that make sense? I'm happy to add a FIXME comment to this effect.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55638/new/

https://reviews.llvm.org/D55638