[PATCH] D55986: hwasan: Use system allocator to realloc and free untagged pointers in interceptor mode.

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis accepted this revision.
eugenis added a comment.
This revision is now accepted and ready to land.

LGTM

Mention that this loader feature is enabled by DF_GLOBAL somewhere in the patch description.

> One limitation is that this scheme doesn't work in reverse: if an
>  instrumented library allocates memory, it must free the memory itself
>  and cannot pass ownership to a system library. In a future change,
>  we may want to expose an API for calling the system allocator so
>  that instrumented libraries can safely transfer ownership of memory
>  to system libraries.

That's unfortunate, but there is not a lot we can do about it. Hopefully, it is not very common in practice.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55986/new/

https://reviews.llvm.org/D55986