[PATCH] D56089: [ELF] A shared object is needed if any of its occurrences is needed

[Rui Ueyama via Phabricator via llvm-commits]

ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: ELF/SymbolTable.cpp:100
+    // it to be added to the dependency list.
     F->parseSoName();
+    DenseMap<StringRef, InputFile *>::iterator It;
----------------
I still prefer to add

  if (errorCount())
    return;

here because there's no reason to group WasInserted and errorCount() in terms of semantics.


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56089/new/

https://reviews.llvm.org/D56089