[PATCH] D56088: Enable posix regex interceptors on linux.
Kamil Rytarowski via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 27 13:46:22 PST 2018
krytarowski added a comment.
In D56088#1341474 <https://reviews.llvm.org/D56088#1341474>, @eugenis wrote:
> Is the purpose of the proposed split to avoid all the #if-s for mac vs linux in that file?
Yes.
> That would be nice, but we would also end up with a lot of code duplication, the same we have now between posix/netbsd/freebsd files. I'm not sure which is better.
The other way around it's not maintainable, on the cost of some duplication.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D56088/new/
https://reviews.llvm.org/D56088
More information about the llvm-commits
mailing list