[PATCH] D56099: [Sanitizer] Add fstab api to FreeBSD/NetBSD

[Kamil Rytarowski via Phabricator via llvm-commits]

krytarowski added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:9062
+  if (spec)
+    COMMON_INTERCEPTOR_READ_RANGE(ctx, spec, REAL(strlen)(spec));
+  void *ret = REAL(getfsspec)(spec);
----------------
krytarowski wrote:
> `REAL(strlen)(spec) + 1` here and in `getfsfile`
Not done.


================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_netbsd.cc:221
 #include <regex.h>
+#include <fstab.h>
 // clang-format on
----------------
Missing `unsigned struct_fstab_sz = sizeof(struct fstab);`


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56099/new/

https://reviews.llvm.org/D56099