[PATCH] D56104: Adjust NetBSD/sha2.cc to be portable to more environments

[Kamil Rytarowski via Phabricator via llvm-commits]

krytarowski added a comment.

In D56104#1341357 <https://reviews.llvm.org/D56104#1341357>, @ruiu wrote:

> Maybe you should just remove test4, 5, 6 and 7? Their test outputs are not checked at all now, and verifying a SHA hash of /etc/fstab doesn't make sense to me as a test.


test4: `char *p = SHA_File(SHASIZE)("/etc/fstab", digest);` we check whether p is accessible according to sanitizers. It's analogously with test 5, 6 and 7.

We want to keep checking this API, even if the output is allowed to be anything. The point is that it's accessible.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56104/new/

https://reviews.llvm.org/D56104