[PATCH] D56099: [Sanitizer] Add fstab api to FreeBSD

[Kamil Rytarowski via Phabricator via llvm-commits]

krytarowski added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:9062
+  if (spec)
+    COMMON_INTERCEPTOR_READ_RANGE(ctx, spec, REAL(strlen)(spec));
+  void *ret = REAL(getfsspec)(spec);
----------------
`REAL(strlen)(spec) + 1` here and in `getfsfile`


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:9358
   INIT_CAPSICUM;
+  INIT_GETFSENT;
   INIT_SHA1;
----------------
Please move it after INIT_CDB.


================
Comment at: test/sanitizer_common/TestCases/Posix/getfsent.cc:28
+
+  printf("First entry: device block '%s', mounted with '%s'\n", fentry->fs_spec, fentry->fs_mntops);
+
----------------
Line too long.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56099/new/

https://reviews.llvm.org/D56099