[PATCH] D56099: [Sanitizer] Add fstab api to FreeBSD

[David CARLIER via Phabricator via llvm-commits]

devnexen marked 2 inline comments as done.
devnexen added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common_interceptors.inc:8030
 
+#if SANITIZER_INTERCEPT_FSTAB
+INTERCEPTOR(struct __sanitizer_fstab *, getfsent) {
----------------
krytarowski wrote:
> Can you relocate it at the end of list of interceptors?
All right.


================
Comment at: lib/sanitizer_common/sanitizer_platform_limits_freebsd.h:632
+
+  struct __sanitizer_fstab {
+    char *fs_spec;
----------------
krytarowski wrote:
> Do we need definition of this struct? It does not seem to be used.
I hesitated because of the returned values of functions (but did not try without). I think we do not need as arguments indeed.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56099/new/

https://reviews.llvm.org/D56099