[PATCH] D56094: [WebAssembly] Fix stack pointer store check in RegStackify

Heejin Ahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 26 14:49:46 PST 2018


aheejin marked an inline comment as done.
aheejin added inline comments.


================
Comment at: lib/Target/WebAssembly/WebAssemblyRegStackify.cpp:196
-      }
-    }
   } else if (MI.hasOrderedMemoryRef()) {
----------------
It looks like this part was added in D34172 and we were using wasm globals for `__stack_pointer` even by then, so I'm not 100% sure what this part meant, but anyway without this patch the modified version of `stackpointer_callee` in `reg-stackify.ll` fails.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56094/new/

https://reviews.llvm.org/D56094





More information about the llvm-commits mailing list