[llvm] r350060 - [gn build] Make NOSORT line actually work

Nico Weber via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 24 15:06:29 PST 2018


Author: nico
Date: Mon Dec 24 15:06:29 2018
New Revision: 350060

URL: http://llvm.org/viewvc/llvm-project?rev=350060&view=rev
Log:
[gn build] Make NOSORT line actually work

GN wants the NOSORT line to be the first line of a comment block, not the last
line.

I sent https://gn-review.googlesource.com/c/gn/+/3560 to support having it in
the last line too, but since it will be a while until everyone has that change
even if it's expected, use the form that works today.

Differential Revision: https://reviews.llvm.org/D56065

Modified:
    llvm/trunk/utils/gn/secondary/clang/lib/Headers/BUILD.gn

Modified: llvm/trunk/utils/gn/secondary/clang/lib/Headers/BUILD.gn
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/gn/secondary/clang/lib/Headers/BUILD.gn?rev=350060&r1=350059&r2=350060&view=diff
==============================================================================
--- llvm/trunk/utils/gn/secondary/clang/lib/Headers/BUILD.gn (original)
+++ llvm/trunk/utils/gn/secondary/clang/lib/Headers/BUILD.gn Mon Dec 24 15:06:29 2018
@@ -34,9 +34,9 @@ copy("Headers") {
     ":arm_headers",
   ]
 
+  # NOSORT
   # Tell `gn format` to not reorder the sources list: Its order matches CMake,
   # and the ordering is alphabetical but ignores leading underscores.
-  # NOSORT
   sources = [
     "adxintrin.h",
     "altivec.h",




More information about the llvm-commits mailing list