[llvm] r350021 - [ORC] Remove redundant instruction from MIPS resolver code. NFC
Simon Atanasyan via llvm-commits
llvm-commits at lists.llvm.org
Sun Dec 23 04:04:56 PST 2018
Author: atanasyan
Date: Sun Dec 23 04:04:55 2018
New Revision: 350021
URL: http://llvm.org/viewvc/llvm-project?rev=350021&view=rev
Log:
[ORC] Remove redundant instruction from MIPS resolver code. NFC
It's redundant to restore the `$a3` register twice.
Modified:
llvm/trunk/include/llvm/ExecutionEngine/Orc/OrcABISupport.h
llvm/trunk/lib/ExecutionEngine/Orc/OrcABISupport.cpp
Modified: llvm/trunk/include/llvm/ExecutionEngine/Orc/OrcABISupport.h
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/ExecutionEngine/Orc/OrcABISupport.h?rev=350021&r1=350020&r2=350021&view=diff
==============================================================================
--- llvm/trunk/include/llvm/ExecutionEngine/Orc/OrcABISupport.h (original)
+++ llvm/trunk/include/llvm/ExecutionEngine/Orc/OrcABISupport.h Sun Dec 23 04:04:55 2018
@@ -245,7 +245,7 @@ class OrcMips32_Base {
public:
static const unsigned PointerSize = 4;
static const unsigned TrampolineSize = 20;
- static const unsigned ResolverCodeSize = 0xfc;
+ static const unsigned ResolverCodeSize = 0xf8;
using IndirectStubsInfo = GenericIndirectStubsInfo<16>;
using JITReentryFn = JITTargetAddress (*)(void *CallbackMgr,
Modified: llvm/trunk/lib/ExecutionEngine/Orc/OrcABISupport.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/ExecutionEngine/Orc/OrcABISupport.cpp?rev=350021&r1=350020&r2=350021&view=diff
==============================================================================
--- llvm/trunk/lib/ExecutionEngine/Orc/OrcABISupport.cpp (original)
+++ llvm/trunk/lib/ExecutionEngine/Orc/OrcABISupport.cpp Sun Dec 23 04:04:55 2018
@@ -604,19 +604,18 @@ void OrcMips32_Base::writeResolverCode(u
0x8fb1001c, // 0xd4: lw $s1,28($sp)
0x8fb00018, // 0xd8: lw $s0,24($sp)
0x8fa70014, // 0xdc: lw $a3,20($sp)
- 0x8fa70014, // 0xe0: lw $a3,20($sp)
- 0x8fa60010, // 0xe4: lw $a2,16($sp)
- 0x8fa5000c, // 0xe8: lw $a1,12($sp)
- 0x8fa40008, // 0xec: lw $a0,8($sp)
- 0x27bd0068, // 0xf4: addiu $sp,$sp,104
- 0x0300f825, // 0xf8: move $ra, $t8
- 0x00000000 // 0xfc: jr $v0/v1
+ 0x8fa60010, // 0xe0: lw $a2,16($sp)
+ 0x8fa5000c, // 0xe4: lw $a1,12($sp)
+ 0x8fa40008, // 0xe8: lw $a0,8($sp)
+ 0x27bd0068, // 0xec: addiu $sp,$sp,104
+ 0x0300f825, // 0xf0: move $ra, $t8
+ 0x00000000 // 0xf4: jr $v0/v1
};
const unsigned ReentryFnAddrOffset = 0x7c; // JIT re-entry fn addr lui
const unsigned CallbackMgrAddrOffset = 0x6c; // Callback manager addr lui
- const unsigned offsett = 0xfc;
+ const unsigned offsett = 0xf4;
memcpy(ResolverMem, ResolverCode, sizeof(ResolverCode));
More information about the llvm-commits
mailing list