[PATCH] D55977: [PowerPC] Fix the bug of ISD::ADDE to set its second return type to glue

Zhang Kang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 21 23:07:20 PST 2018


ZhangKang added a comment.

In D55977#1339258 <https://reviews.llvm.org/D55977#1339258>, @hfinkel wrote:

> In D55977#1339255 <https://reviews.llvm.org/D55977#1339255>, @hfinkel wrote:
>
> > LGTM
>
>
> Also, if there's a way to have a non-asserts-required test case, that would be useful. How did you notice the problem?


@hfinkel , I use `-debug-only` option for this test case, this option need asserts. I have referenced other test cases which use `-debug-only` option.
In fact, for this case,  only in legalize phase, we can find the error information, so I check the debug information in `legalize-types`.

I notice the bug of second return type for the ISD::ADDE when I am working on another issue about ISD::ADDE, whose code has not been submitted.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55977/new/

https://reviews.llvm.org/D55977





More information about the llvm-commits mailing list