[PATCH] D55997: Add support for LLVM profile for NetBSD

[Kamil Rytarowski via Phabricator via llvm-commits]

krytarowski added a comment.

In D55997#1340069 <https://reviews.llvm.org/D55997#1340069>, @vsk wrote:

> Thanks, this patch lgtm.
>
> In D55997#1338996 <https://reviews.llvm.org/D55997#1338996>, @krytarowski wrote:
>
> > @joerg I was trying to change atexit(3) calls to C++ destructors or GCC destructiors (`__attribute__((destructor))`), but none of that worked.
> >
> > For the former:
> >
> >   /public/llvm-build/lib/clang/8.0.0/lib/netbsd/libclang_rt.profile-x86_64.a(InstrProfilingRuntime.cc.o): In function `__clang_call_terminate':
> >   InstrProfilingRuntime.cc:(.text.__clang_call_terminate[__clang_call_terminate]+0x2): undefined reference to `__cxa_begin_catch'
> >   InstrProfilingRuntime.cc:(.text.__clang_call_terminate[__clang_call_terminate]+0x7): undefined reference to `std::terminate()'
> >   /public/llvm-build/lib/clang/8.0.0/lib/netbsd/libclang_rt.profile-x86_64.a(InstrProfilingRuntime.cc.o):(.data.DW.ref.__gxx_personality_v0[DW.ref.__gxx_personality_v0]+0x0): undefined reference to `__gxx_personality_v0'
> >   clang-8: error: linker command failed with exit code 1 (use -v to see invocation)
> >
> >
> > For the latter hangs and crashes of many/all tests.
>
>
> Looks like you're missing the C++ runtime (libcxxabi or libcxx, IIRC, although you may be using libstdc++)?


I will defer for now this to @joerg to find an atexit(3) replacement to fix instrprof-dlopen-dlclose-gcov.test.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55997/new/

https://reviews.llvm.org/D55997