[PATCH] D56015: Allow new comdat symbols to be added as a result of LTO.

Teresa Johnson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 21 11:32:04 PST 2018


tejohnson added a comment.

In D56015#1339411 <https://reviews.llvm.org/D56015#1339411>, @pcc wrote:

> LTO optimization passes shouldn't be adding new comdats. Any comdats contained in a bitcode file should be explicit in its symbol table so that they get resolved during symbol resolution. So we should probably fix the bug in whichever pass is adding the comdats instead.


This patch I assume is due to an issue @xur had with a patch to enable context-sensitive pgo (instrumentation is added in the lto backends). He can give details on the profile related symbol being added.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D56015/new/

https://reviews.llvm.org/D56015





More information about the llvm-commits mailing list