[PATCH] D55975: [X86] Remove x86ISD::INC/DEC. Just select them from X86ISD::ADD/SUB at isel time
    Craig Topper via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Fri Dec 21 09:11:17 PST 2018
    
    
  
craig.topper marked an inline comment as done.
craig.topper added inline comments.
================
Comment at: lib/Target/X86/X86ISelDAGToDAG.cpp:2311
+        }
+      }
+    } else {
----------------
RKSimon wrote:
> (style) return true here for ISD::CopyToReg special case and remove else + indentation below?
We’re inside the outer for loop over users of the flags. We may have a mix of selected and unselected users. We can’t return true until we’ve visited them all.
Repository:
  rL LLVM
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55975/new/
https://reviews.llvm.org/D55975
    
    
More information about the llvm-commits
mailing list