[PATCH] D54749: Saturating float to int casts: Basics [1/n]
Nikita Popov via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 21 07:34:46 PST 2018
nikic added a comment.
In D54749#1329486 <https://reviews.llvm.org/D54749#1329486>, @t.p.northover wrote:
> I think the consistency argument is good, so I'm in favour of the structure you chose now. My main issue at the moment is the tests: hard-coding register usage leads to very fragile tests.
Is there any way to avoid hardcoded register usage in an automated manner? With vector coverage, this is probably going to need about 15k lines of tests just for two platforms, and they're going to change quite a bit until codegen is finalized. I don't think it's productive to write and rewrite those by hand.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54749/new/
https://reviews.llvm.org/D54749
More information about the llvm-commits
mailing list