[PATCH] D52002: Omit range checks from jump tables when lowering switches with unreachable default
Ayonam Ray via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 21 03:34:30 PST 2018
ayonam updated this revision to Diff 179258.
ayonam marked an inline comment as done.
ayonam added a comment.
Resubmitting the patch with the corrections suggested earlier.
@hans
Sorry I missed that comment. I don't think we need that check (SI->getNumCases() > 0). There was some particular case that probably prompted me to add that check. But on second thoughts, that check is not required.
I have also corrected the other minor issues suggested by you. Resubmitting the patch.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D52002/new/
https://reviews.llvm.org/D52002
Files:
lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp
lib/CodeGen/SelectionDAG/SelectionDAGBuilder.h
test/CodeGen/AArch64/switch-unreachable-default.ll
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D52002.179258.patch
Type: text/x-patch
Size: 7400 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181221/50b5b9f8/attachment.bin>
More information about the llvm-commits
mailing list