[PATCH] D55921: [AArch64] Add command-line option for SB

Diogo N. Sampaio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 21 03:01:09 PST 2018


dnsampaio marked 2 inline comments as done.
dnsampaio added inline comments.


================
Comment at: lib/Target/AArch64/AArch64.td:309
 
+def FeatureSB : SubtargetFeature<"sb", "HasSB",
+  "true", "Enable v8.5 Speculation Barrier" >;
----------------
olista01 wrote:
> I don't think this is needed. You've moved the SB instruction from FeatureSpecCtrl to this new feature, but the SB instruction was the only thing in FeatureSpecCtrl, which is now empty.
That is indeed true, I've confused it with SpecRestrict that holds Systems operands.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55921/new/

https://reviews.llvm.org/D55921





More information about the llvm-commits mailing list