[PATCH] D55956: [WebAssembly] Fix invalid machine instrs in -O0, verify in tests

[Heejin Ahn via Phabricator via llvm-commits]

aheejin added a comment.

Sorry for nits after the commit :(



================
Comment at: llvm/trunk/test/CodeGen/WebAssembly/simd-noopt.ll:6
+;; llc after fastisel produced machineinstrs that used registers that
+;; had never been defined.
+
----------------
Sorry for the after-comment: Could you specify that this is a stop-gap thing that's effective only until v2i64 is implemented? Not sure if it is clear why this simd test does not produce simd instructions at all, if someone doesn't know the history of `-wasm-enable-unimplemented-simd`. (This is what I meant in the first place, sorry if I wasn't clear)


================
Comment at: llvm/trunk/test/CodeGen/WebAssembly/simd-noopt.ll:9
+target datalayout = "e-m:e-p:32:32-i64:64-n32:64-S128"
+target triple = "wasm32-unknown-unknown-wasm"
+
----------------
no need of `-wasm` at the end


================
Comment at: llvm/trunk/test/CodeGen/WebAssembly/simd-noopt.ll:20
+
+attributes #0 = { noinline optnone }
----------------
You can delete this and add `-fast-isel` to the command line


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55956/new/

https://reviews.llvm.org/D55956