[PATCH] D55983: [gn build] Embed __TEXT __info_plist section into clang binary on macOS

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 20 19:38:23 PST 2018


thakis marked an inline comment as done.
thakis added inline comments.


================
Comment at: llvm/utils/gn/secondary/clang/tools/driver/BUILD.gn:38
+if (host_os == "mac") {
+  action("write_info_plist") {
+    script = "//llvm/utils/gn/build/write_cmake_config.py"
----------------
It finally dawned on my that I should make a write_cmake_config() template and use that everywhere I currently have an action that calls write_cmake_config.py. I'll do that soon.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55983/new/

https://reviews.llvm.org/D55983





More information about the llvm-commits mailing list