[PATCH] D55969: [BasicAA] Fix AA bug on dynamic allocas and stackrestore

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 20 17:26:25 PST 2018


efriedma added inline comments.


================
Comment at: llvm/lib/Transforms/Scalar/MemCpyOptimizer.cpp:1064
+  LLVM_DEBUG(dbgs() << "MemCpyOptPass: Forwarding memcpy->memcpy src:\n"
+                    << *MDep << '\n' << *M << '\n');
 
----------------
(Please commit this separately.)


================
Comment at: llvm/test/Transforms/MemCpyOpt/stackrestore.ll:30
+  ret i32 0
+}
+
----------------
Please add a corresponding testcase without the stacksave/stackrestore so the test doesn't bitrot.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55969/new/

https://reviews.llvm.org/D55969





More information about the llvm-commits mailing list