[PATCH] D55970: [GlobalISel][AArch64] Add support for widening G_FCEIL

Amara Emerson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 20 17:00:30 PST 2018


aemerson accepted this revision.
aemerson added a comment.
This revision is now accepted and ready to land.

LGTM with minor change.



================
Comment at: lib/CodeGen/GlobalISel/LegalizerHelper.cpp:948
+  case TargetOpcode::G_FCEIL:
+    assert(TypeIdx == 0 && "Should only widen when TypeIdx == 0?");
+    Observer.changingInstr(MI);
----------------
We should return UnableToLegalize instead of asserting.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55970/new/

https://reviews.llvm.org/D55970





More information about the llvm-commits mailing list