[PATCH] D55909: [ARMISelLowering] Add CPSR to live-ins of newly created blocks, if required.
Eli Friedman via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 20 16:54:31 PST 2018
efriedma added inline comments.
================
Comment at: lib/Target/ARM/ARMISelLowering.cpp:9009
+ exitMBB->addLiveIn(ARM::CPSR);
+ }
+
----------------
Hang on... doesn't the loop clobber CPSR? I think rather than add the live-in marking like this, we need to mark COPY_STRUCT_BYVAL_I32 with "Defs = [CPSR]".
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55909/new/
https://reviews.llvm.org/D55909
More information about the llvm-commits
mailing list