[llvm] r349836 - [gn check] Unbreak check-lld if llvm_install_binutils_symlinks is false
Nico Weber via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 20 13:57:12 PST 2018
Author: nico
Date: Thu Dec 20 13:57:12 2018
New Revision: 349836
URL: http://llvm.org/viewvc/llvm-project?rev=349836&view=rev
Log:
[gn check] Unbreak check-lld if llvm_install_binutils_symlinks is false
The check-lld target was missing the dependency on llvm-nm and llvm-objdump in that case.
Differential Revision: https://reviews.llvm.org/D55941
Modified:
llvm/trunk/utils/gn/secondary/llvm/tools/llvm-nm/BUILD.gn
llvm/trunk/utils/gn/secondary/llvm/tools/llvm-objdump/BUILD.gn
Modified: llvm/trunk/utils/gn/secondary/llvm/tools/llvm-nm/BUILD.gn
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/gn/secondary/llvm/tools/llvm-nm/BUILD.gn?rev=349836&r1=349835&r2=349836&view=diff
==============================================================================
--- llvm/trunk/utils/gn/secondary/llvm/tools/llvm-nm/BUILD.gn (original)
+++ llvm/trunk/utils/gn/secondary/llvm/tools/llvm-nm/BUILD.gn Thu Dec 20 13:57:12 2018
@@ -13,10 +13,11 @@ if (llvm_install_binutils_symlinks) {
# //:llvm-nm depends on this symlink target, see comment in //BUILD.gn.
group("symlinks") {
+ deps = [
+ ":llvm-nm",
+ ]
if (llvm_install_binutils_symlinks) {
- deps = [
- ":nm",
- ]
+ deps += [ ":nm" ]
}
}
Modified: llvm/trunk/utils/gn/secondary/llvm/tools/llvm-objdump/BUILD.gn
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/utils/gn/secondary/llvm/tools/llvm-objdump/BUILD.gn?rev=349836&r1=349835&r2=349836&view=diff
==============================================================================
--- llvm/trunk/utils/gn/secondary/llvm/tools/llvm-objdump/BUILD.gn (original)
+++ llvm/trunk/utils/gn/secondary/llvm/tools/llvm-objdump/BUILD.gn Thu Dec 20 13:57:12 2018
@@ -13,10 +13,11 @@ if (llvm_install_binutils_symlinks) {
# //:llvm-nm depends on this symlink target, see comment in //BUILD.gn.
group("symlinks") {
+ deps = [
+ ":llvm-objdump",
+ ]
if (llvm_install_binutils_symlinks) {
- deps = [
- ":objdump",
- ]
+ deps += [ ":objdump" ]
}
}
More information about the llvm-commits
mailing list