[PATCH] D55629: [elfabi] Add support for reading DT_SONAME from binaries

Thu Dec 20 10:59:06 PST 2018

amontanez marked 4 inline comments as done.
amontanez added inline comments.

================
Comment at: llvm/test/tools/llvm-elfabi/binary-read-no-dt-strsz.test:19
+    Size:            32
+  - Name:            .dynstr
+    Type:            SHT_STRTAB
----------------
jakehehrlich wrote:
> So yaml2obj actually does support dynamic symbols but I'm not sure that it supports .dynamic. grep for "DynamicSymbols" in .test and .yaml files in the code base. There should be a yaml2obj test that uses this feature. You might find proper support for .dynamic as well.
Unfortunately, the only mention of the .dynamic section in yaml2obj is when sh_entsize of SHT_DYNAMIC is populated. If I recall correctly, using DynamicSymbols causes .dynstr to be overwritten.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55629/new/

https://reviews.llvm.org/D55629