[PATCH] D55941: [gn check] Unbreak check-lld if llvm_install_binutils_symlinks is false

[Nico Weber via Phabricator via llvm-commits]

thakis created this revision.
thakis added a reviewer: phosek.

The check-lld target was missing the dependency on llvm-nm and llvm-objdump in that case.


https://reviews.llvm.org/D55941

Files:
  llvm/utils/gn/secondary/llvm/tools/llvm-nm/BUILD.gn
  llvm/utils/gn/secondary/llvm/tools/llvm-objdump/BUILD.gn


Index: llvm/utils/gn/secondary/llvm/tools/llvm-objdump/BUILD.gn
===================================================================
--- llvm/utils/gn/secondary/llvm/tools/llvm-objdump/BUILD.gn
+++ llvm/utils/gn/secondary/llvm/tools/llvm-objdump/BUILD.gn
@@ -13,10 +13,11 @@
 
 # //:llvm-nm depends on this symlink target, see comment in //BUILD.gn.
 group("symlinks") {
+  deps = [
+    ":llvm-objdump",
+  ]
   if (llvm_install_binutils_symlinks) {
-    deps = [
-      ":objdump",
-    ]
+    deps += [ ":objdump" ]
   }
 }
 
Index: llvm/utils/gn/secondary/llvm/tools/llvm-nm/BUILD.gn
===================================================================
--- llvm/utils/gn/secondary/llvm/tools/llvm-nm/BUILD.gn
+++ llvm/utils/gn/secondary/llvm/tools/llvm-nm/BUILD.gn
@@ -13,10 +13,11 @@
 
 # //:llvm-nm depends on this symlink target, see comment in //BUILD.gn.
 group("symlinks") {
+  deps = [
+    ":llvm-nm",
+  ]
   if (llvm_install_binutils_symlinks) {
-    deps = [
-      ":nm",
-    ]
+    deps += [ ":nm" ]
   }
 }
 


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55941.179096.patch
Type: text/x-patch
Size: 1026 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181220/014d875f/attachment.bin>