[PATCH] D55911: GlobalISel: Correct example PartialMapping table

Quentin Colombet via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 20 09:46:20 PST 2018


qcolombet added a comment.

Hi Matt,

You're right.

Your fix is actually not completely correct for the next comments too:

- The 2x seems weird since the two inputs are on different lines and we would think the comment is meant for this one line alone. Could you have this comment spans the two lines
- the example with the break down does not match what's in the array any more. You have to fix line 122 (add the partial 32-32) and lines 127-128 too reflect the indices changes.

Thanks for fixing this.
Quentin


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55911/new/

https://reviews.llvm.org/D55911





More information about the llvm-commits mailing list