[PATCH] D55919: [DebugInfo] Omit location list entries with empty ranges

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 20 09:00:51 PST 2018


aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Looks generally good to me.



================
Comment at: lib/CodeGen/AsmPrinter/DwarfDebug.cpp:1188
+      // variable.
+      if (DIExpr->isFragment())
+        OpenRanges.push_back(Value);
----------------
why not just move the condition two lines further down?


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55919/new/

https://reviews.llvm.org/D55919





More information about the llvm-commits mailing list