[PATCH] D55898: [x86] add movddup specialization for build vector lowering (PR37502)

[Sanjay Patel via Phabricator via llvm-commits]

spatel marked an inline comment as done.
spatel added inline comments.


================
Comment at: test/CodeGen/X86/build-vector-128.ll:530
 ; SSE41-32-NEXT:    movsd {{.*#+}} xmm0 = mem[0],zero
-; SSE41-32-NEXT:    insertps {{.*#+}} xmm0 = xmm0[0,1],mem[0],xmm0[3]
-; SSE41-32-NEXT:    insertps {{.*#+}} xmm0 = xmm0[0,1,2],mem[0]
+; SSE41-32-NEXT:    movddup {{.*#+}} xmm0 = xmm0[0,0]
 ; SSE41-32-NEXT:    retl
----------------
RKSimon wrote:
> Why didn't this fold the load?
I think we're missing a tablegen pattern for this?
        t30: v2f64,ch = X86ISD::VZEXT_LOAD<(load 8 from %fixed-stack.1, align 4)> t0, FrameIndex:i32<-1>
      t28: v2f64 = X86ISD::MOVDDUP t30



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55898/new/

https://reviews.llvm.org/D55898