[PATCH] D55881: [llvm-objcopy] [COFF] Add support for removing symbols

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 20 05:44:28 PST 2018


mstorsjo updated this revision to Diff 179052.
mstorsjo retitled this revision from "[llvm-objcopy] [COFF] Add support for removing symbols and sections" to "[llvm-objcopy] [COFF] Add support for removing symbols".
mstorsjo edited the summary of this revision.
mstorsjo added a comment.

Split out code for removing sections to a later patch. Maintaining a map from symbol name to Symbol object within the Object class, and keeping the relocation target symbol name in a Reloc struct together with the coff_relocation struct. This hopefully addresses most of @jakehehrlich's feedback.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55881/new/

https://reviews.llvm.org/D55881

Files:
  test/tools/llvm-objcopy/COFF/X86/lit.local.cfg
  test/tools/llvm-objcopy/COFF/X86/remove-local-symbols.s
  test/tools/llvm-objcopy/COFF/X86/remove-symbol1.s
  test/tools/llvm-objcopy/COFF/X86/remove-symbol2.s
  tools/llvm-objcopy/CMakeLists.txt
  tools/llvm-objcopy/COFF/COFFObjcopy.cpp
  tools/llvm-objcopy/COFF/Object.cpp
  tools/llvm-objcopy/COFF/Object.h
  tools/llvm-objcopy/COFF/Reader.cpp
  tools/llvm-objcopy/COFF/Reader.h
  tools/llvm-objcopy/COFF/Writer.cpp
  tools/llvm-objcopy/COFF/Writer.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55881.179052.patch
Type: text/x-patch
Size: 14246 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181220/e8d84fe8/attachment.bin>


More information about the llvm-commits mailing list