[PATCH] D55886: [llvm-objcopy] - Do not drop the OS/ABI and ABIVersion fields of ELF header

George Rimar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 20 00:25:01 PST 2018


grimar marked an inline comment as done.
grimar added a comment.

Thanks, everyone for looking!



================
Comment at: tools/llvm-objcopy/ELF/Object.cpp:706
   Obj->Type = ET_REL;
+  Obj->OSABI = 0;
+  Obj->ABIVersion = 0;
----------------
rupprecht wrote:
> Not that it makes any difference in functionality, but I think using ELFOSABI_NONE explicitly (as it was in the place it's moved from) would be better
Will do.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55886/new/

https://reviews.llvm.org/D55886





More information about the llvm-commits mailing list