[PATCH] D55681: [llvm] API for encoding/decoding DWARF discriminators.

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin marked 2 inline comments as done.
mtrofin added inline comments.


================
Comment at: include/llvm/IR/DebugInfoMetadata.h:1605-1606
+  /// value.
+  static unsigned encodeDiscriminator(unsigned BD, unsigned DF, unsigned CI,
+                                      bool &Success);
+
----------------
dblaikie wrote:
> Would Expected<unsigned> or Optional<unsigned> be more suitable here rather than using a bool as an out parameter to report errors?
Done - also adjusted current APIs  for consistency.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55681/new/

https://reviews.llvm.org/D55681