[PATCH] D55619: [elfabi] Add option to manually specify file read format

Armando Montanez via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 19 16:19:19 PST 2018


amontanez marked 2 inline comments as done.
amontanez added inline comments.


================
Comment at: llvm/tools/llvm-elfabi/llvm-elfabi.cpp:40
+                          "TBE", "Read `input` as text-based ELF stub"),
+               clEnumValN(FileFormat::TBE,
+                          "tbe", "(alias for TBE)"),
----------------
jhenderson wrote:
> I take it there's no way of making the input argument match-up case insensitive? I know that options can be case-insensitive if the command line library is used appropriately.
I looked into this for a while and couldn't find any way make these case insensitive. I assumed it would be possible too. I realized that the other command line options weren't case insensitive either, so I've set these to be lowercase only for consistency.


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55619/new/

https://reviews.llvm.org/D55619





More information about the llvm-commits mailing list