[PATCH] D55904: [WebAssembly] Gate unimplemented SIMD ops on flag

Wed Dec 19 15:51:26 PST 2018

aheejin added a comment.

Looks like it is not easy to only guard `f32x4` type in `td` files in the current implementation. If we make sure we expand them in ISel, do we need a separate guard for td files?

================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:731
 // Square root: sqrt
+let Predicates = [HasSIMD128, HasUnimplementedSIMD] in
 defm SQRT : SIMDUnaryFP<fsqrt, "sqrt", 151>;
----------------
Doesn't this guard both `f32x4.sqrt` and `f64x2.sqrt`?

================
Comment at: lib/Target/WebAssembly/WebAssemblyInstrSIMD.td:755
 // Division: div
+let Predicates = [HasSIMD128, HasUnimplementedSIMD] in
 defm DIV : SIMDBinaryFP<fdiv, "div", 157>;
----------------
Doesn't this guard both `f32x4.div` and `f64x2.div`?

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55904/new/

https://reviews.llvm.org/D55904