[PATCH] D55740: Fix sanitizer tool list used to generate sanitizer_common tests to be up-to-date.

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 19 15:20:23 PST 2018


vitalybuka added inline comments.


================
Comment at: test/sanitizer_common/CMakeLists.txt:20
+    endif()
+  endforeach()
 endif()
----------------
delcypher wrote:
> vitalybuka wrote:
> > Could you please and submit patch add printing of SUPPORTED_TOOLS into existing code and wait some time 
> > so we will have something on buildbots to compare after the current one is landed
> @vitalybuka Just to clarify what you're asking for (I've got this wrong before)
> 
> - Submit a separate patch that prints out what `SUPPORTED_TOOLS` is now (i.e. not what this patch tries to make `SUPPORTED_TOOLS` become).
> - Wait for some builds to happen
> - Rebase this patch and then look at the output of several bots to see in which scenarios we are running tests today and try to decide if we should change this patch to try and preserve the existing scenarios or expand on them.
> 
> Correct?
yes.



Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55740/new/

https://reviews.llvm.org/D55740





More information about the llvm-commits mailing list