[PATCH] D55886: [llvm-objcopy] - Do not drop the OS/ABI and ABIVersion fields of ELF header

[Jake Ehrlich via Phabricator via llvm-commits]

jakehehrlich accepted this revision.
jakehehrlich added a comment.

LGTM, I'd like James's approval and my only comment is about a feature we can add after this if its needed. James is also out on leave so go ahead and land this.



================
Comment at: tools/llvm-objcopy/ELF/Object.cpp:703
 
 template <class ELFT> void BinaryELFBuilder<ELFT>::initFileHeader() {
   Obj->Flags = 0x0;
----------------
I'd like @jhenderson to comment if their use case might ever require them to specify what the OSABI and/or ABIVersion might need to be set via a flag for the BianryELFBuilder case.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55886/new/

https://reviews.llvm.org/D55886