[PATCH] D54889: Fiber support for thread sanitizer

Wed Dec 19 13:07:58 PST 2018

741g added a comment.

In D54889#1334710 <https://reviews.llvm.org/D54889#1334710>, @741g wrote:

> In D54889#1334702 <https://reviews.llvm.org/D54889#1334702>, @yuri wrote:
>
> > In D54889#1334678 <https://reviews.llvm.org/D54889#1334678>, @741g wrote:
> >
> > > https://android-review.googlesource.com/c/platform/external/qemu/+/844675
> > >
> > > Latest version of patch doesn't work with QEMU anymore, at least with those annotations. Error log:
> > >
> > > Do you know what I'm doing wrong here?
> >
> >
> >
> >  Please check if adding __attribute__((always_inline)) for start_switch_fiber() and finish_switch_fiber() helps
>
>
> That worked, thanks! Sorry, I had updated the patch with a refactoring the meantime that probably actually caused the break.

QEMU status: Fewer false positives now; there are many warnings that seem more real now, mostly about not atomically reading variables that got atomically updated. There might be other issues as well.

Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54889/new/

https://reviews.llvm.org/D54889