[PATCH] D55857: [asan] Prevent folding of globals with redzones

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 19 13:00:24 PST 2018


vitalybuka marked an inline comment as done.
vitalybuka added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/AddressSanitizer.cpp:2203
     if (NewGlobal->hasLocalLinkage() || NewGlobal->hasLinkOnceODRLinkage() ||
         NewGlobal->hasWeakODRLinkage()) {
       ODRIndicator = ConstantExpr::getIntToPtr(ConstantInt::get(IntptrTy, -1),
----------------
pcc wrote:
> Can we remove the linkonce_odr and weak_odr checks from here now?
D55899


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55857/new/

https://reviews.llvm.org/D55857





More information about the llvm-commits mailing list