[PATCH] D52116: Introduce llvm.loop.parallel_accesses and llvm.access.group metadata.

Hal Finkel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 19 12:38:07 PST 2018


hfinkel accepted this revision.
hfinkel added a comment.

Aside from the requested renaming (see below), this LGTM.



================
Comment at: include/llvm/Analysis/LoopInfo.h:1016
+/// is used as an access group.
+bool isAccessGroup(MDNode *AccGroup);
+
----------------
I'd prefer to name this isValidAsAccessGroup() (because the function does not actually determine whether the MD node *is* an access group, but rather, whether it might be valid to use it as one).


Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D52116/new/

https://reviews.llvm.org/D52116





More information about the llvm-commits mailing list