[PATCH] D55896: [MC] [AArch64] Support resolving fixups for :abs_g0: etc.

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Dec 19 12:10:25 PST 2018


efriedma created this revision.
efriedma added reviewers: dmgreen, peter.smith, pcc, mstorsjo.
Herald added subscribers: kristof.beyls, javed.absar.

This requires a bit more code than other fixups, to distingush between abs_g0/abs_g1/etc.  Actually, I think some of the other fixups are missing some checks, but I won't try to address that here.

I haven't seen any real-world code that uses a construct like this, but it clearly should work, and we're considering using it in the implementation of localescape/localrecover on Windows (see https://reviews.llvm.org/D53540).  I've verified that binutils produces the same code as llvm-mc for the testcase.

This currently doesn't include support for the *_s variants (that requires a bit more work to set the instruction opcode).


Repository:
  rL LLVM

https://reviews.llvm.org/D55896

Files:
  lib/Target/AArch64/MCTargetDesc/AArch64AsmBackend.cpp
  test/MC/AArch64/fixup-absolute.s
  test/MC/AArch64/fixup-out-of-range.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D55896.178934.patch
Type: text/x-patch
Size: 5389 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20181219/3b63aaaf/attachment.bin>


More information about the llvm-commits mailing list