[PATCH] D55682: [ELF] Support defining __start/__stop symbols as hidden

[Petr Hosek via Phabricator via llvm-commits]

phosek marked an inline comment as done.
phosek added inline comments.


================
Comment at: lld/ELF/Writer.cpp:1849
     return;
-  addOptionalRegular(Saver.save("__start_" + S), Sec, 0, STV_PROTECTED);
-  addOptionalRegular(Saver.save("__stop_" + S), Sec, -1, STV_PROTECTED);
+  uint8_t B = Config->ZHiddenStartStopSymbols ? STV_HIDDEN : STV_PROTECTED;
+  addOptionalRegular(Saver.save("__start_" + S), Sec, 0, B);
----------------
grimar wrote:
> What is `B` stands for? I would expect to see `V` (Visibility).
`Binding` (that's what `addOptionalRegular`'s argument is called as well), would you prefer `V`?


Repository:
  rLLD LLVM Linker

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55682/new/

https://reviews.llvm.org/D55682