[PATCH] D55894: [X86][SSE] Auto upgrade PADDS/PSUBS intrinsics to SADD_SAT/SSUB_SAT generic intrinsics (llvm)

Wed Dec 19 11:33:22 PST 2018

craig.topper added inline comments.

================
Comment at: test/CodeGen/X86/pic-load-remat.ll:1
 ; RUN: llc < %s -mtriple=i686-apple-darwin -mattr=+sse2 -relocation-model=pic | grep psllw | grep pb

----------------
Looks like its only looking for a load on psllw so it probably doesn't matter what else is going on. I'm fine with the generic intrinsics.

================
Comment at: test/Transforms/InstCombine/X86/x86-adds-subs.ll:22
 ; CHECK-LABEL: @sse2_adds_b_constant_overflow(
 ; CHECK-NEXT:    ret <16 x i8> <i8 2, i8 4, i8 6, i8 8, i8 10, i8 12, i8 14, i8 16, i8 18, i8 20, i8 127, i8 24, i8 26, i8 28, i8 30, i8 127>
 ;
----------------
Probably should move this out to generic. Feels weird to test upgraded intrinsics.

Repository:
  rL LLVM

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55894/new/

https://reviews.llvm.org/D55894